NoopApp/noop
5
8
Fork 5
Code Issues 20 Pull requests 1 Releases 27 Wiki Activity

WRONG. WAS SUBMITTING TO MIRROR GH. #18

Closed
A wants to merge 16 commits from A:fix/datasources-backup-extension into main
pull from: A:fix/datasources-backup-extension
merge into: NoopApp:main
Conversation 1 Commits 16 Files changed 4 +296 -71
A commented 2026-06-17 18:54:18 +00:00
Contributor
Copy link

What this PR does

The Backup & Move card in the Data Sources screen was passing "strand-backup.noopdb" as the suggested filename to the system file picker. The .noopdb extension belongs to the old plain-SQLite format that was retired in favour of the compressed .noopbak format (ZIP-wrapped SQLite, typically 80-90% smaller).

DataBackup.exportTo has always written the compressed format - the stale extension was the only bug. A user who accepted the default filename would end up with a .noopdb file that actually contained a ZIP, which:

  • breaks any tool that tries to open it as a SQLite file by extension
  • breaks import on iOS/Mac if they detect format by extension before magic bytes

Details:

  • Fixed: exportLauncher.launch("strand-backup.noopdb") ? exportLauncher.launch("noop-backup-${java.time.LocalDate.now()}.noopbak") in DataSourcesScreen.kt
  • Filename now matches the format used by the Settings screen export and the format documented in the changelog

No logic changes - DataBackup.exportTo already writes a correct single-entry ZIP with deflate compression.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • CI / tooling

How it was tested

Built and ran assembleFullRelease locally. Tapped Export in Data Sources - file picker now suggests noop-backup-2026-06-17.noopbak. Imported the exported file on the same device - import succeeded and prompted restart as expected.

Checklist

  • Swift package tests pass for any package I touched (swift test in Packages/<name>)
  • Android unit tests pass if I touched android/ (./gradlew testFullDebugUnitTest)
  • No new build warnings introduced
  • UI changes use only StrandDesign tokens - no hardcoded colors, fonts, or spacing
  • No hardcoded hex frame bytes; protocol facts live in the schema / decoders
  • Follows the conventions in docs/CONTRIBUTING.md
  • I did not commit generated output (Strand.xcodeproj/) or any secrets/keystores

Related issues

## What this PR does The **Backup & Move** card in the Data Sources screen was passing `"strand-backup.noopdb"` as the suggested filename to the system file picker. The `.noopdb` extension belongs to the old plain-SQLite format that was retired in favour of the compressed `.noopbak` format (ZIP-wrapped SQLite, typically 80-90% smaller). `DataBackup.exportTo` has always written the compressed format - the stale extension was the only bug. A user who accepted the default filename would end up with a `.noopdb` file that actually contained a ZIP, which: - breaks any tool that tries to open it as a SQLite file by extension - breaks import on iOS/Mac if they detect format by extension before magic bytes **Details:** - **Fixed:** `exportLauncher.launch("strand-backup.noopdb")` ? `exportLauncher.launch("noop-backup-${java.time.LocalDate.now()}.noopbak")` in `DataSourcesScreen.kt` - Filename now matches the format used by the Settings screen export and the format documented in the changelog No logic changes - `DataBackup.exportTo` already writes a correct single-entry ZIP with deflate compression. ## Type of change - [x] Bug fix - [ ] New feature - [ ] Refactor / cleanup - [ ] Documentation - [ ] CI / tooling ## How it was tested Built and ran `assembleFullRelease` locally. Tapped Export in Data Sources - file picker now suggests `noop-backup-2026-06-17.noopbak`. Imported the exported file on the same device - import succeeded and prompted restart as expected. ## Checklist - [ ] Swift package tests pass for any package I touched (`swift test` in `Packages/<name>`) - [x] Android unit tests pass if I touched `android/` (`./gradlew testFullDebugUnitTest`) - [x] No new build warnings introduced - [x] UI changes use only `StrandDesign` tokens - no hardcoded colors, fonts, or spacing - [x] No hardcoded hex frame bytes; protocol facts live in the schema / decoders - [x] Follows the conventions in [`docs/CONTRIBUTING.md`](../docs/CONTRIBUTING.md) - [x] I did not commit generated output (`Strand.xcodeproj/`) or any secrets/keystores ## Related issues <!-- Closes #N -->
A added 16 commits 2026-06-17 18:54:19 +00:00
A closed this pull request 2026-06-17 18:55:14 +00:00
A changed title from fix(android): use .noopbak extension for Backup & Move export in Data Sources to WRONG. WAS SUBMITTING TO MIRROR GH. 2026-06-17 19:00:57 +00:00
NoopApp commented 2026-06-17 19:17:36 +00:00
Owner
Copy link

Hey — thanks for the clean fix in #19, and genuinely appreciate how you're running the fork: licence kept, original credited, and donations pointed back to the creator rather than diverted. That's exactly the right spirit, and community mirrors like yours are welcome — they make the project harder to kill, which is the whole point right now. 🙏

One heads-up that helps both of us: the original GitHub org was suspended, so the canonical home is now https://noop.fans/NoopApp/noop (code, releases, wiki, issues — all there). Your fork's "donation addresses are in the original repository" pointer currently lands on the dead GitHub repo, so if you repoint it to noop.fans the addresses (and everything else) will actually resolve for people who want to chip in. Thanks again for pitching in. 🖤

Hey — thanks for the clean fix in #19, and genuinely appreciate how you're running the fork: licence kept, original credited, and donations pointed back to the creator rather than diverted. That's exactly the right spirit, and community mirrors like yours are welcome — they make the project harder to kill, which is the whole point right now. 🙏 One heads-up that helps both of us: the original GitHub org was suspended, so the **canonical home is now https://noop.fans/NoopApp/noop** (code, releases, wiki, issues — all there). Your fork's "donation addresses are in the original repository" pointer currently lands on the dead GitHub repo, so if you repoint it to noop.fans the addresses (and everything else) will actually resolve for people who want to chip in. Thanks again for pitching in. 🖤

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
discussion

   
enhancement

   
help wanted

   
multi-source

   
question

   
roadmap
No labels
bug
discussion
enhancement
help wanted
multi-source
question
roadmap
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
NoopApp/noop!18
No description provided.